[SOLR-13335] Upgrade to velocity 2.0 and velocity-tools 3.0

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.1, 9.0
• Assignee: Kevin Risden
• Reporter: Kevin Risden
• Created: 19/Mar/19 18:58
• Updated: 12/May/22 00:26
• Resolved: 25/Mar/19 14:21

Description

As part of looking to remove old commons-lang in SOLR-9079, found that velocity depends on it. Upgrading Velocity would allow completely removing commons-lang

Copy some detail from SOLR-9079 investigation:

• solr/contrib/velocity/ivy.xml doesn't even reference commons-lang
• velocity 1.7 was released - 2010-11-29
• LUCENE-5249 from 2013 was the last time velocity was changed in lucene/ivy-versions.properties

• velocity-tools 2.0 has an optional dependency on commons-lang
• velocity 1.7 has a hard dependency on commons-lang.

Upgrading velocity 1.7 -> 2.0

• http://velocity.apache.org/engine/2.0/upgrading.html
• Change velocity to velocity-engine-core
• upgrades commons-lang to commons-lang3

So if we want to finish removing commons-lang, we need to upgrade velocity.

Issue Links

• causes: SOLR-13351 Workaround for VELOCITY-908
• incorporates: SOLR-9920 error fixes included for did_you_mean.vm and richtext_doc.vm velocity examples
• is depended upon by: SOLR-13342 Remove dom4j from Solr
• relates to: SOLR-10705 Upgrade Velocity's version of jquery from 1.7.2 to 2.1.3
• relates to: SOLR-9079 Remove commons-lang as a dependency
• links to: GitHub Pull Request #612