Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.0, master (9.0)
    • Component/s: None
    • Labels:
      None

      Description

      i recently fixed tweaked TriLevelCompositeIdRoutingTest to lower the node/shard count on TEST_NIGHTLY because it was constantly causing an OOM.

      While skimming this test i realized that (other then the OOM, or other catastrophic failure in solr) it was garunteed to never fail, rgardless of what bugs might exist in solr when routing an update/query:

      • it doesn't sanity check that any docs are returned from any query – so if commit does nothing and it gets no results from each of the shard queries, it will still pass
      • the getKey() method – which throws away anything after the last "!" in a String – is called redundently on it's own output to populate an idMap ... but not before the first result is used do to acontainsKey assertion on that same idMap
        • ie: if app42/7!user33!doc1234 is a uniqueKey value, then app42/7!user33 is what the assert !containsKey checks the Map for, but app42/7 is what gets put in the Map

        Attachments

        1. SOLR-13210_demonstrate_broken_test.patch
          2 kB
          Chris M. Hostetter
        2. SOLR-13210.patch
          8 kB
          Chris M. Hostetter

          Issue Links

            Activity

              People

              • Assignee:
                hossman Chris M. Hostetter
                Reporter:
                hossman Chris M. Hostetter
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: