Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-12801

Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Open
    • Priority: Critical
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      A single issue to counteract the single issue adding tons of annotations, the continued addition of new flakey tests, and the continued addition of flakiness to existing tests.

      Lots more to come.

        Attachments

          Issue Links

          1.
          Remove static modifier from Overseer queue access. Sub-task Open Mark Miller
          2.
          Introduce more checks for shutdown and closed to improve clean close and shutdown. Sub-task Open Mark Miller
          3.
          Introduce AlreadyClosedException to clean up silly close / shutdown logging. Sub-task Open Mark Miller
          4.
          Replace cluster state polling with ZkStateReader#waitFor. Sub-task Open Mark Miller
          5.
          Fix all tests in org.apache.solr.search and begin a defense of them. Sub-task Open Mark Miller
          6.
          Fix all tests in org.apache.solr.update and begin a defense of them. Sub-task Open Mark Miller
          7.
          Fix all Solr tests to work with ant beast. Sub-task Open Mark Miller
          8.
          Introduce a new set of Mock objects that cover key parts of the system and are easy to use. Sub-task Open Mark Miller
          9.
          Resurrect regular test beasting reports. Sub-task Open Mark Miller
          10.
          Separate Solr unit tests and integration tests. Sub-task Open Unassigned
          11.
          Add great developer documentation for writing tests. Sub-task Open Unassigned
          12.
          ant test (without badapples=false) should pass easily for developers. Sub-task Open Mark Miller
          13.
          Harden LeaderTragicEventTest. Sub-task Open Mark Miller
          14.
          The new AutoScaling tests are way to flaky and need special attention. Sub-task Open Unassigned
          15.
          Harden AutoAddReplicasPlanActionTest#testSimple Sub-task Open Unassigned
          16.
          Harden ChaosMonkeySafeLeaderWithPullReplicasTest Sub-task Open Unassigned
          17.
          Harden MaxSizeAutoCommitTest Sub-task Closed Hoss Man
          18.
          Harden HttpSolrCallGetCoreTest Sub-task Open Mark Miller
          19.
          Harden TestSimGenericDistributedQueue. Sub-task Closed Jason Gerlowski
          20.
          Harden TestSQLHandler. Sub-task Closed Joel Bernstein
          21.
          clean up suspicious ExecutorService lifecycles in MiniSolrCloudCluster Sub-task Closed Hoss Man
          22.
          Harden BasicAuthIntegrationTest. Sub-task Open Mark Miller
          23.
          many cloud/autoscaling tests are using System.currentTimeMillis() for timing comparisons (under the covers) Sub-task Closed Hoss Man
          24.
          Harden SaslZkACLProviderTest. Sub-task Open Erick Erickson
          25.
          refactor and harden common 'suspend-trigger' patern in autoscaling test setup Sub-task Closed Hoss Man
          26.
          Redesign integration tests for nodeAdded/nodeLost trigger state restoration Sub-task Closed Hoss Man
          27.
          Harden SearchRateTriggerIntegrationTest Sub-task Closed Hoss Man
          28.
          Testing of TLOG Replicas needs to be re-instated, may be hiding bugs Sub-task Open Unassigned
          29.
          Need reliable example (Test) of how to use TestInjection.failReplicaRequests Sub-task Open Unassigned
          30.
          TriLevelCompositeIdRoutingTest makes no sense -- can never fail Sub-task Closed Hoss Man
          31.
          when TestInjection.nonGracefullClose causes a TestShutdownFailError, test is garunteed tofail due to leaked objects (causes failures in (Hdfs)RestartWhileUpdatingTest) Sub-task Open Unassigned
          32.
          numerous problems with LIROnShardRestartTest Sub-task Resolved Unassigned
          33.
          restore ability for BaseDistributedSearchTestCase subclasses to use null keys in "handle" when comparing responses Sub-task Open Mark Miller

            Activity

              People

              • Assignee:
                markrmiller@gmail.com Mark Miller
                Reporter:
                markrmiller@gmail.com Mark Miller
              • Votes:
                3 Vote for this issue
                Watchers:
                18 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h
                  1h