[SOLR-11456] HealthCheckHandlerTest.testHealthCheckHandler() asserts nothing useful

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.0
• Assignee: Chris M. Hostetter
• Reporter: Chris M. Hostetter
• Created: 10/Oct/17 01:04
• Updated: 16/Jan/20 06:34
• Resolved: 11/Oct/17 22:32

Description

The meat of HealthCheckHandlerTest.testHealthCheckHandler() currently looks like this...

      while (live_nodes.size() == 1 && counter++ < 100) {
        Thread.sleep(100);
        live_nodes = cluster.getSolrClient().getZkStateReader().getClusterState().getLiveNodes();
      }

      try {
        req.process(httpSolrClient);
      } catch (HttpSolrClient.RemoteSolrException e) {
        assertTrue(e.getMessage(), e.getMessage().contains("Host Unavailable"));
        assertEquals(SolrException.ErrorCode.SERVICE_UNAVAILABLE.code, e.code());
      }

• nothing actually asserts that live_nodes.size() != 1 – so the loop could just exit after 100 iterations w/o any changes to hte system happening.
• instead of using expectThrows, the only assertions are inside the catch block – if the code (unexpectedly) succeeds the test will not fail (false positive)

Issue Links

• incorporates: SOLR-11457 HealthCheckHandlerTest.testHealthCheckHandlerSolrJ() non-reproducible failures -- test order/timing realted?
• is fixed by: SOLR-14191 Restore fixes for HealthCheckHandlerTest.testHealthCheckHandler() made by SOLR-11456
• is related to: SOLR-11457 HealthCheckHandlerTest.testHealthCheckHandlerSolrJ() non-reproducible failures -- test order/timing realted?
• relates to: SOLR-11126 Node-level health check handler