Details
-
Improvement
-
Status: Open
-
Major
-
Resolution: Unresolved
-
None
-
None
-
None
-
None
Description
The point of SoftAutoCommitTest is to ensure that auto-commits fire when expected.
The timing based checks on those autocommits are a semi-neccessary evil to ensure that the test doesn't get false positives due to some other commits.
The test also sanity checks that auto-commits result in newSearcher events if/when they should – but these also (currently) have timing checks ot ensure that they happen "fast enough" ... this seems unneccessary (given the purpose of hte test) and broken (there's no guarantee/expectation how fast a searcher will open, even though the test assumes it will be a number relative to the autocommit setting.
we should relax these assertions, and just ensure that the searcher eventually opens in a non-absurd amount of time, not fail if it isn't some specific math function relative to other events.
Attachments
Attachments
Issue Links
- relates to
-
SOLR-11053 Improve SoftAutoCommitTest to the point that we can delete AutoCommitTest and HardAutoCommitTest
- Closed
Here's an example of a jenkins failure (the full logs are no longer available)...
https://builds.apache.org/job/Lucene-Solr-Tests-7.x/163/
The intent here is to "verify" that the searcher was open because of the soft commit – not the hard commit. But there is no garuntee that a newSearcher event triggered by the (auto)SoftCommit will finish before a subsequent hard commit.
we should remove this (type of) check and instead either: