[SOLR-11454] relax newSearcher based time checks in SoftAutoCommitTest

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Chris M. Hostetter
• Created: 09/Oct/17 22:11
• Updated: 08/Jun/19 15:12

Description

The point of SoftAutoCommitTest is to ensure that auto-commits fire when expected.

The timing based checks on those autocommits are a semi-neccessary evil to ensure that the test doesn't get false positives due to some other commits.
The test also sanity checks that auto-commits result in newSearcher events if/when they should – but these also (currently) have timing checks ot ensure that they happen "fast enough" ... this seems unneccessary (given the purpose of hte test) and broken (there's no guarantee/expectation how fast a searcher will open, even though the test assumes it will be a number relative to the autocommit setting.

we should relax these assertions, and just ensure that the searcher eventually opens in a non-absurd amount of time, not fail if it isn't some specific math function relative to other events.

Issue Links

• relates to: SOLR-11053 Improve SoftAutoCommitTest to the point that we can delete AutoCommitTest and HardAutoCommitTest