Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11163

Normalizer fails to restore itself when reload or restart solr cores.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.6
    • Fix Version/s: 7.0, master (8.0)
    • Component/s: contrib - LTR
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Normalizer fails to restore itself from json file of its parameters when reload or restart solr cores.
      This is because Normalizer#paramsToMap generates Map of parameters with double quoted like below:

      {
        "min": "\"0.0\"",
        "max": "\"1.0\""
      }
      

      With the example above, Normalizer#newInstance fails to invoke setters due to the failure of Float#parseFloat("\"0.0\"").

      1. SOLR-11163.patch
        4 kB
        Christine Poerschke
      2. SOLR-11163.patch
        9 kB
        Yuki Yano

        Issue Links

          Activity

          Hide
          cpoerschke Christine Poerschke added a comment -

          Hello Yuki Yano - thanks for identifying this problem and creating a patch to fix it. I have separated out your TestModelManagerPersistence improvements into SOLR-11187 and attaching here slightly revised Test(MinMax|Standard)Normalizer changes i.e. in the implTest(MinMax|Standard) method some \" quotes needed removing to make all the tests pass again.

          Show
          cpoerschke Christine Poerschke added a comment - Hello Yuki Yano - thanks for identifying this problem and creating a patch to fix it. I have separated out your TestModelManagerPersistence improvements into SOLR-11187 and attaching here slightly revised Test(MinMax|Standard)Normalizer changes i.e. in the implTest(MinMax|Standard) method some \" quotes needed removing to make all the tests pass again.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c297180cca19eff3f9ace04ef8e56e8418151bd0 in lucene-solr's branch refs/heads/master from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c297180 ]

          SOLR-11163: Fix contrib/ltr Normalizer persistence after solr core reload or restart.
          (Yuki Yano via Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit c297180cca19eff3f9ace04ef8e56e8418151bd0 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c297180 ] SOLR-11163 : Fix contrib/ltr Normalizer persistence after solr core reload or restart. (Yuki Yano via Christine Poerschke)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit defefef87d78e86320bf178ac19f92a73f930277 in lucene-solr's branch refs/heads/branch_7x from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=defefef ]

          SOLR-11163: Fix contrib/ltr Normalizer persistence after solr core reload or restart.
          (Yuki Yano via Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit defefef87d78e86320bf178ac19f92a73f930277 in lucene-solr's branch refs/heads/branch_7x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=defefef ] SOLR-11163 : Fix contrib/ltr Normalizer persistence after solr core reload or restart. (Yuki Yano via Christine Poerschke)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5c136fd8fdfe27d2c3b1e379951db4c14bb2ae17 in lucene-solr's branch refs/heads/branch_7_0 from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5c136fd ]

          SOLR-11163: Fix contrib/ltr Normalizer persistence after solr core reload or restart.
          (Yuki Yano via Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5c136fd8fdfe27d2c3b1e379951db4c14bb2ae17 in lucene-solr's branch refs/heads/branch_7_0 from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5c136fd ] SOLR-11163 : Fix contrib/ltr Normalizer persistence after solr core reload or restart. (Yuki Yano via Christine Poerschke)
          Hide
          cpoerschke Christine Poerschke added a comment -

          Thanks Yuki Yano!

          Show
          cpoerschke Christine Poerschke added a comment - Thanks Yuki Yano !
          Hide
          yuyano Yuki Yano added a comment -

          Thank you for your prompt response!

          Show
          yuyano Yuki Yano added a comment - Thank you for your prompt response!

            People

            • Assignee:
              cpoerschke Christine Poerschke
              Reporter:
              yuyano Yuki Yano
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development