Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10421

solr/contrib/ltr (MinMax|Standard)Normalizer.paramsToMap needs to save float as string

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.4, 6.4.1, 6.4.2, 6.5
    • Fix Version/s: 6.5.1, 6.6, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Please see Jianxiong Dong's solr learning_to_rank (normalizer) unmatched argument type issue email on the user mailing list for details on how this bug manifests.

      Implementation choice background:

      • If the number were to be saved as a number then 4.2 could be considered either as a float or as a double and hence the normalizer classes would need setters for both those possibilities. Equally, 42.0 could be saved as just 42 which then could be either an int or a long and so again setters for both possibilities would be needed. All this complexity is avoided by saving the number as a string. The class has convenience float setters which can be handy for use in tests.

        Attachments

        1. SOLR-10421.patch
          3 kB
          Christine Poerschke

          Issue Links

            Activity

              People

              • Assignee:
                cpoerschke Christine Poerschke
                Reporter:
                cpoerschke Christine Poerschke
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: