Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10421

solr/contrib/ltr (MinMax|Standard)Normalizer.paramsToMap needs to save float as string

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.4, 6.4.1, 6.4.2, 6.5
    • Fix Version/s: 6.5.1, 6.6, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Please see Jianxiong Dong's solr learning_to_rank (normalizer) unmatched argument type issue email on the user mailing list for details on how this bug manifests.

      Implementation choice background:

      • If the number were to be saved as a number then 4.2 could be considered either as a float or as a double and hence the normalizer classes would need setters for both those possibilities. Equally, 42.0 could be saved as just 42 which then could be either an int or a long and so again setters for both possibilities would be needed. All this complexity is avoided by saving the number as a string. The class has convenience float setters which can be handy for use in tests.
      1. SOLR-10421.patch
        3 kB
        Christine Poerschke

        Issue Links

          Activity

          Hide
          cpoerschke Christine Poerschke added a comment - - edited

          Minimal fix and test change. Ideally i would like this included in the stop-and-restart test case(s) to exactly capture the reported observed behavior, though in practice this might have to do for now with 6.5.1 release timeline in mind.

          Show
          cpoerschke Christine Poerschke added a comment - - edited Minimal fix and test change. Ideally i would like this included in the stop-and-restart test case(s) to exactly capture the reported observed behavior, though in practice this might have to do for now with 6.5.1 release timeline in mind.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit dfa342bc90f8f3012e26169286ee61d42e9b15cf in lucene-solr's branch refs/heads/master from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dfa342b ]

          SOLR-10421: Fix params persistence for solr/contrib/ltr (MinMax|Standard)Normalizer classes.
          (Jianxiong Dong, Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit dfa342bc90f8f3012e26169286ee61d42e9b15cf in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dfa342b ] SOLR-10421 : Fix params persistence for solr/contrib/ltr (MinMax|Standard)Normalizer classes. (Jianxiong Dong, Christine Poerschke)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 503179248312f8610d074e2e67fdf48454a8940a in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5031792 ]

          SOLR-10421: Fix params persistence for solr/contrib/ltr (MinMax|Standard)Normalizer classes.
          (Jianxiong Dong, Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 503179248312f8610d074e2e67fdf48454a8940a in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5031792 ] SOLR-10421 : Fix params persistence for solr/contrib/ltr (MinMax|Standard)Normalizer classes. (Jianxiong Dong, Christine Poerschke)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d70269bd612cf682beb9c785236ea2517ff5f795 in lucene-solr's branch refs/heads/branch_6_5 from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d70269b ]

          SOLR-10421: Fix params persistence for solr/contrib/ltr (MinMax|Standard)Normalizer classes.
          (Jianxiong Dong, Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit d70269bd612cf682beb9c785236ea2517ff5f795 in lucene-solr's branch refs/heads/branch_6_5 from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d70269b ] SOLR-10421 : Fix params persistence for solr/contrib/ltr (MinMax|Standard)Normalizer classes. (Jianxiong Dong, Christine Poerschke)
          Hide
          cpoerschke Christine Poerschke added a comment -

          Thanks Jianxiong Dong!

          Show
          cpoerschke Christine Poerschke added a comment - Thanks Jianxiong Dong!

            People

            • Assignee:
              cpoerschke Christine Poerschke
              Reporter:
              cpoerschke Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development