Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10700

In 7.0 stop using the PostingsHighlighter

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0
    • Component/s: highlighter
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      In 7.0 we should stop using the PostingsHighlighter (see LUCENE-7815 wherein it may not even exist anymore). Instead we can mark it deprecated and configure the UnifiedHighlighter to behave like the PostingsHighlighter.

        Issue Links

          Activity

          Hide
          dsmiley David Smiley added a comment -

          Pretty simple patch. Logs a warning on initialization when you use it in solrconfig.xml but probably won't if you use it via hl.method=postings. It's cool that with this change the existing tests pass without changes.

          Suggested CHANGES.txt upgrading section note:

          • The PostingsSolrHighlighter is now deprecated in favor of the UnifiedSolrHighlighter.
          Show
          dsmiley David Smiley added a comment - Pretty simple patch. Logs a warning on initialization when you use it in solrconfig.xml but probably won't if you use it via hl.method=postings . It's cool that with this change the existing tests pass without changes. Suggested CHANGES.txt upgrading section note: The PostingsSolrHighlighter is now deprecated in favor of the UnifiedSolrHighlighter.
          Hide
          dsmiley David Smiley added a comment -

          I plan to commit this Tuesday the 23rd in absence of any feedback.

          Show
          dsmiley David Smiley added a comment - I plan to commit this Tuesday the 23rd in absence of any feedback.
          Hide
          dsmiley David Smiley added a comment -

          New patch, updating apispec/core.SchemaEdit.addField.json (v2 api) which has user documentation that includes references to the PostingsHighlighter. While I was at it I tweaked these docs a bit to add some clarity as well as some term vector related options.

          Show
          dsmiley David Smiley added a comment - New patch, updating apispec/core.SchemaEdit.addField.json (v2 api) which has user documentation that includes references to the PostingsHighlighter. While I was at it I tweaked these docs a bit to add some clarity as well as some term vector related options.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2218ded2afd0231005d81bd16c6b0c114ef32546 in lucene-solr's branch refs/heads/master from David Smiley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2218ded ]

          SOLR-10700: Convert PostingsSolrHighlighter to extend UnifiedSolrHighlighter

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2218ded2afd0231005d81bd16c6b0c114ef32546 in lucene-solr's branch refs/heads/master from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2218ded ] SOLR-10700 : Convert PostingsSolrHighlighter to extend UnifiedSolrHighlighter
          Hide
          hossman Hoss Man added a comment -

          David: if hl.method=postings is deprecated in 6x then why mention it in the master ref-guide at all?

          Show
          hossman Hoss Man added a comment - David: if hl.method=postings is deprecated in 6x then why mention it in the master ref-guide at all?
          Hide
          dsmiley David Smiley added a comment -

          So do you suggest I update 6.x & 6.6 ASAP to include the highlighting.adoc change I did here... and then on master further remove any mention of the PostingsHighlighter?

          Show
          dsmiley David Smiley added a comment - So do you suggest I update 6.x & 6.6 ASAP to include the highlighting.adoc change I did here... and then on master further remove any mention of the PostingsHighlighter?
          Hide
          hossman Hoss Man added a comment -

          IIUC the changes you made, then yeah ... even if the code is in master for backcompat, if it's deprecated/removed/mocked via other code, then there is no reason to distract people with it in the ref guide – we should only doc the stuff we actually suggest/recommend that people use.

          Show
          hossman Hoss Man added a comment - IIUC the changes you made, then yeah ... even if the code is in master for backcompat, if it's deprecated/removed/mocked via other code, then there is no reason to distract people with it in the ref guide – we should only doc the stuff we actually suggest/recommend that people use.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f246717ab36611dbb10097cd8b013118c70664b4 in lucene-solr's branch refs/heads/branch_6x from David Smiley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f246717 ]

          SOLR-10700: Mark PostingsSolrHighlighter as deprecated (code and ref guide)
          partially cherry picked from 2218ded

          Show
          jira-bot ASF subversion and git services added a comment - Commit f246717ab36611dbb10097cd8b013118c70664b4 in lucene-solr's branch refs/heads/branch_6x from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f246717 ] SOLR-10700 : Mark PostingsSolrHighlighter as deprecated (code and ref guide) partially cherry picked from 2218ded
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f237b8db508bbbaa600a297c57196cd87abd7c0c in lucene-solr's branch refs/heads/branch_6_6 from David Smiley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f237b8d ]

          SOLR-10700: Mark PostingsSolrHighlighter as deprecated (code and ref guide)
          partially cherry picked from 2218ded

          (cherry picked from commit f246717)

          Show
          jira-bot ASF subversion and git services added a comment - Commit f237b8db508bbbaa600a297c57196cd87abd7c0c in lucene-solr's branch refs/heads/branch_6_6 from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f237b8d ] SOLR-10700 : Mark PostingsSolrHighlighter as deprecated (code and ref guide) partially cherry picked from 2218ded (cherry picked from commit f246717)
          Hide
          dsmiley David Smiley added a comment -

          The deprecation of Postings*Solr*Highlighter (and de-emphasis but still present in ref guide) was just committed for 6.6.

          The issue title, "Stop using the PostingsHighlighter" is for 7.0. Later today I'll completely remove PostingsHighlighter references from 7.0/master.

          Show
          dsmiley David Smiley added a comment - The deprecation of Postings*Solr*Highlighter (and de-emphasis but still present in ref guide) was just committed for 6.6. The issue title, "Stop using the PostingsHighlighter" is for 7.0. Later today I'll completely remove PostingsHighlighter references from 7.0/master.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 872ed81cc971646c10fdb27b23ffe6ca7decd91a in lucene-solr's branch refs/heads/master from David Smiley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=872ed81 ]

          SOLR-10700: Remove PostingsHighlighter references from docs

          Show
          jira-bot ASF subversion and git services added a comment - Commit 872ed81cc971646c10fdb27b23ffe6ca7decd91a in lucene-solr's branch refs/heads/master from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=872ed81 ] SOLR-10700 : Remove PostingsHighlighter references from docs

            People

            • Assignee:
              dsmiley David Smiley
              Reporter:
              dsmiley David Smiley
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development