Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0
    • Component/s: modules/highlighter
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The UnifiedHighlighter is derived from the PostingsHighlighter, which should be quite obvious to anyone who cares to look at them. There is no feature in the PH that is not also present in the UH. The PH is marked as lucene.experimental so we may remove it in 7.0. The upgrade path is pretty easy given the API similarity. By removing the PH, the goal is to ease maintenance. Some issues lately have been applicable to both of these highlighters which is annoying to apply twice. In one case I forgot to. And of course there is user confusion by having both.

      What I propose to do in this issue is move CustomSeparatorBreakIterator and WholeBreakIterator out of the postingshighlight package into the uhighlight package (or perhaps add a common or util should future highlighters need them?). Then of course remove postingshighlight package.

        Issue Links

          Activity

          Hide
          dsmiley David Smiley added a comment -

          The attached patch does what I said. I didn't bother creating a utils or common package for the CustomSeparatorBreakIterator or WholeBreakIterator.

          I have the Solr changes in here too but I will file a separate issue.

          Show
          dsmiley David Smiley added a comment - The attached patch does what I said. I didn't bother creating a utils or common package for the CustomSeparatorBreakIterator or WholeBreakIterator. I have the Solr changes in here too but I will file a separate issue.
          Hide
          dsmiley David Smiley added a comment -

          I plan to commit this as soon as Tuesday next week in the absence of further feedback. It does include the change to UnifiedSolrHighlighter to refer to the correct package names of where the break iterators were moved to.

          Suggested CHANGES.txt in API Changes:

          • Removed the PostingsHighlighter; use the UnifiedHighlighter instead, which was derived from the PH. WholeBreakIterator and CustomSeparatorBreakIterator were moved to UH's package.
          Show
          dsmiley David Smiley added a comment - I plan to commit this as soon as Tuesday next week in the absence of further feedback. It does include the change to UnifiedSolrHighlighter to refer to the correct package names of where the break iterators were moved to. Suggested CHANGES.txt in API Changes: Removed the PostingsHighlighter; use the UnifiedHighlighter instead, which was derived from the PH. WholeBreakIterator and CustomSeparatorBreakIterator were moved to UH's package.
          Hide
          ichattopadhyaya Ishan Chattopadhyaya added a comment -

          If the plan is to remove PH in 7.0, shouldn't we deprecate it now in 6.6 (there's a window of opportunity here).

          Show
          ichattopadhyaya Ishan Chattopadhyaya added a comment - If the plan is to remove PH in 7.0, shouldn't we deprecate it now in 6.6 (there's a window of opportunity here).
          Hide
          dsmiley David Smiley added a comment -

          It would be nice to; yes. I thought I may have missed the 6.6 release for doing that (but I didn't consider it essential). I'll commit a simple deprecation to PostingsHighlighter.java in some hours from now; okay? Do you think it deserves a separate issue?

          Show
          dsmiley David Smiley added a comment - It would be nice to; yes. I thought I may have missed the 6.6 release for doing that (but I didn't consider it essential). I'll commit a simple deprecation to PostingsHighlighter.java in some hours from now; okay? Do you think it deserves a separate issue?
          Hide
          ichattopadhyaya Ishan Chattopadhyaya added a comment -

          I think it should be fine with this issue itself.

          Show
          ichattopadhyaya Ishan Chattopadhyaya added a comment - I think it should be fine with this issue itself.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c74f4a0ae0532d95fc4e5512838e22d64e9b8ecc in lucene-solr's branch refs/heads/branch_6x from David Smiley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c74f4a0 ]

          LUCENE-7815: Deprecate the PostingsHighlighter

          Show
          jira-bot ASF subversion and git services added a comment - Commit c74f4a0ae0532d95fc4e5512838e22d64e9b8ecc in lucene-solr's branch refs/heads/branch_6x from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c74f4a0 ] LUCENE-7815 : Deprecate the PostingsHighlighter
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c41a6f19a4685fa4a7acf304f109a6a2084321ab in lucene-solr's branch refs/heads/branch_6_6 from David Smiley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c41a6f1 ]

          LUCENE-7815: Deprecate the PostingsHighlighter

          (cherry picked from commit c74f4a0)

          Show
          jira-bot ASF subversion and git services added a comment - Commit c41a6f19a4685fa4a7acf304f109a6a2084321ab in lucene-solr's branch refs/heads/branch_6_6 from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c41a6f1 ] LUCENE-7815 : Deprecate the PostingsHighlighter (cherry picked from commit c74f4a0)
          Hide
          ichattopadhyaya Ishan Chattopadhyaya added a comment -

          David Smiley, should we add the deprecation information to the 6.6 upgrade notes for Solr?

          Show
          ichattopadhyaya Ishan Chattopadhyaya added a comment - David Smiley , should we add the deprecation information to the 6.6 upgrade notes for Solr?
          Hide
          dsmiley David Smiley added a comment -

          Ishan Chattopadhyaya I don't think so; https://issues.apache.org/jira/browse/SOLR-10700 (at 7.0) is enough I think.

          Show
          dsmiley David Smiley added a comment - Ishan Chattopadhyaya I don't think so; https://issues.apache.org/jira/browse/SOLR-10700 (at 7.0) is enough I think.
          Hide
          ichattopadhyaya Ishan Chattopadhyaya added a comment -

          Great, thanks!

          Show
          ichattopadhyaya Ishan Chattopadhyaya added a comment - Great, thanks!
          Hide
          dsmiley David Smiley added a comment -

          Updated patch to remove PH from the benchmark module.

          Show
          dsmiley David Smiley added a comment - Updated patch to remove PH from the benchmark module.
          Hide
          hossman Hoss Man added a comment -

          david: now that the ref-guide is in git, can you please make sure to remove mentions of the PostingsHighlither from the asciidoc files as well when you commit these changes to master?

          Show
          hossman Hoss Man added a comment - david: now that the ref-guide is in git, can you please make sure to remove mentions of the PostingsHighlither from the asciidoc files as well when you commit these changes to master?
          Hide
          dsmiley David Smiley added a comment -

          Hoss Man I think you meant for your comment to be on SOLR-10700 and on that issue I did update highlighting.adoc.

          Show
          dsmiley David Smiley added a comment - Hoss Man I think you meant for your comment to be on SOLR-10700 and on that issue I did update highlighting.adoc.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0d3c73eaa2dd26af73461fd6ec3494bc12edbe8a in lucene-solr's branch refs/heads/master from David Smiley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0d3c73e ]

          LUCENE-7815: Removed the PostingsHighlighter

          Show
          jira-bot ASF subversion and git services added a comment - Commit 0d3c73eaa2dd26af73461fd6ec3494bc12edbe8a in lucene-solr's branch refs/heads/master from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0d3c73e ] LUCENE-7815 : Removed the PostingsHighlighter
          Hide
          hossman Hoss Man added a comment -

          Hmmm ... ok, i guess i'm confused by the distinction, but i'll ask my followup question in SOLR-10700

          Show
          hossman Hoss Man added a comment - Hmmm ... ok, i guess i'm confused by the distinction, but i'll ask my followup question in SOLR-10700
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 85c3ae2040d175ddc0af2147ccde2c9b7599ef59 in lucene-solr's branch refs/heads/master from David Smiley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=85c3ae2 ]

          LUCENE-7815: Remove more PostingsHighlighter remnants

          Show
          jira-bot ASF subversion and git services added a comment - Commit 85c3ae2040d175ddc0af2147ccde2c9b7599ef59 in lucene-solr's branch refs/heads/master from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=85c3ae2 ] LUCENE-7815 : Remove more PostingsHighlighter remnants

            People

            • Assignee:
              dsmiley David Smiley
              Reporter:
              dsmiley David Smiley
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development