[SOLR-10671] tweak SolrMetricReporter implementations' init/validate/start logic

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 7.0
• Assignee: Christine Poerschke
• Reporter: Christine Poerschke
• Created: 11/May/17 11:56
• Updated: 08/Jun/17 09:20
• Resolved: 08/Jun/17 09:20

Description

This ticket proposes to

• add abstract doInit method to the SolrMetricReporter base class
• turn Solr(Cluster|Shard)Reporter.validate into Solr(Cluster|Shard)Reporter.doInit
• factor out Solr(Ganglia|Graphite|Slf4j)Reporter.doInit from Solr(Ganglia|Graphite|Slf4j)Reporter.validate

Motivation and Intention:

• Consistency w.r.t. what logic SolrMetricReport implementations should place in which method.
• Even reporters that are not enabled to pass the validate() check.
• The validate() method to have no (init-ialising) side effects.

Issue Links

• relates to: SOLR-10823 add reporting period to SolrMetricReporter base class