Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10671

tweak SolrMetricReporter implementations' init/validate/start logic

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0
    • Component/s: None
    • Labels:
      None

      Description

      This ticket proposes to

      • add abstract doInit method to the SolrMetricReporter base class
      • turn Solr(Cluster|Shard)Reporter.validate into Solr(Cluster|Shard)Reporter.doInit
      • factor out Solr(Ganglia|Graphite|Slf4j)Reporter.doInit from Solr(Ganglia|Graphite|Slf4j)Reporter.validate

      Motivation and Intention:

      • Consistency w.r.t. what logic SolrMetricReport implementations should place in which method.
      • Even reporters that are not enabled to pass the validate() check.
      • The validate() method to have no (init-ialising) side effects.

        Attachments

        1. SOLR-10671.patch
          11 kB
          Christine Poerschke
        2. SOLR-10671.patch
          9 kB
          Christine Poerschke

          Issue Links

            Activity

              People

              • Assignee:
                cpoerschke Christine Poerschke
                Reporter:
                cpoerschke Christine Poerschke
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: