[SM-3856] OSGi bundle for spring-core 5.1.1 is missing import of "org.apache.commons.logging.impl"

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Duplicate
• Affects Version/s: bundles-2018.10
• Component/s: bundles
• Assignee: Freeman Yue Fang
• Reporter: Olaf Otto
• Created: 12/Nov/18 00:43
• Updated: 12/Nov/18 00:53
• Resolved: 12/Nov/18 00:53

Description

The CompositeLog class of spring-core statically initializes an instance of org.apache.commons.logging.impl.NoOpLog. The bundle thus requires the impl package. Sample stacktrace:

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter': Instantiation of bean failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter]: Constructor threw exception; nested exception is java.lang.NoClassDefFoundError: Could not initialize class org.springframework.core.log.CompositeLog

The import should be in the form

org.apache.commons.logging.impl;version="[1.1.1,2)"

I also noted that the commons logging imports are currently on resolution=optional. I believe they are not optional any more.

Issue Links

• duplicates: SM-3853 Missing import: org.apache.commons.logging.impl in spring-core-5.1.1.RELEASE