[SM-3853] Missing import: org.apache.commons.logging.impl in spring-core-5.1.1.RELEASE

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: bundles-2018.10
• Fix Version/s: bundles-2018.11
• Component/s: bundles
• Assignee: Freeman Yue Fang
• Reporter: Ben Humphreys
• Created: 08/Nov/18 05:44
• Updated: 12/Nov/18 08:49
• Resolved: 12/Nov/18 00:48

Description

As of Spring 5.1 spring-core depends on org.apache.commons.logging.impl

See: https://github.com/spring-projects/spring-framework/blob/v5.1.1.RELEASE/spring-core/src/main/java/org/springframework/core/log/CompositeLog.java#L23

org.apache.servicemix.bundles.spring-core in the 2018.10 bundles does import org.apache.commons.logging but not org.apache.commons.logging.impl

The failure looks like this:

Caused by: java.lang.NoClassDefFoundError: org/apache/commons/logging/impl/NoOpLog
 at org.springframework.core.log.CompositeLog.<clinit>(CompositeLog.java:35)
 at org.springframework.core.log.LogDelegateFactory.getCompositeLog(LogDelegateFactory.java:62)
 at org.springframework.http.HttpLogging.forLog(HttpLogging.java:68)
 at org.springframework.http.HttpLogging.forLogName(HttpLogging.java:57)
 at org.springframework.http.converter.AbstractHttpMessageConverter.<init>(AbstractHttpMessageConverter.java:54)
 at org.springframework.http.converter.StringHttpMessageConverter.<init>(StringHttpMessageConverter.java:70)
 at org.springframework.http.converter.StringHttpMessageConverter.<init>(StringHttpMessageConverter.java:62)
 at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:172)
 ... 9 common frames omitted

Issue Links

• is duplicated by: SM-3856 OSGi bundle for spring-core 5.1.1 is missing import of "org.apache.commons.logging.impl"
• relates to: SM-3812 Create OSGi bundles for Spring 5.1.1.RELEASE