[SLING-9036] Sling Models: SlingHttpServletRequestWrapper.adaptTo() unwraps before adapting

• Type: New Feature
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: Sling Models
• Assignee: Unassigned
• Reporter: Henry Kuijpers
• Created: 28/Jan/20 22:46
• Updated: 22/Nov/22 08:37

Description

Sling Model:

@Model(adaptables = SlingHttpServletRequest.class, adapters = MySlingModel.class)
class MySlingModel { 
  @Inject
  public MySlingModel(@Self SlingHttpServletRequest req) {
    logger.log(req.getResourceBundle().getClass().getName());   
  }
}

Calling code:

// req obtained via JSP/HTL
final SlingHttpServletRequest myWrappedReq = new SlingHttpServletRequestWrapper(req) {
  @Override
  public ResourceBundle getResourceBundle() {
    return new MyCustomResourceBundle();
  }
};
 
final MySlingModel myModel = myWrappedReq.adaptTo(MySlingModel.class);

I would expect the log file to contain "MyCustomResourceBundle". Instead it contains "NullResourceBundle". 

This is because the request is being "unwrapped" when doing the adaptTo() call: It keeps on delegating to the wrapped request. This should not have happened, i.e. how can we otherwise overwrite (parts of) requests and resources? 

See also: https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/wrappers/SlingHttpServletRequestWrapper.java#L147

Issue Links

• is related to: SLING-5668 Models: Leverage ServletRequestListener.requestDestroyed for calling DisposalCallback in case the model was created from a request