[SLING-5668] Models: Leverage ServletRequestListener.requestDestroyed for calling DisposalCallback in case the model was created from a request

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Sling Models Impl 1.2.6
• Fix Version/s: Models Impl 1.4.6
• Component/s: Extensions
• Assignee: Justin Edelson
• Reporter: Konrad Windszus
• Created: 18/Apr/16 11:28
• Updated: 29/Jan/20 14:11
• Resolved: 08/Dec/17 15:20

Description

Due to SLING-5664 I had to remove usage of SlingScriptHelper in the OSGiServiceInjector. Therefore now always the DisposableCallbackRegistry is used to release service references. That mechanism relies on a dedicated thread (https://github.com/apache/sling/blob/b864f105617c0ac7c2d525bfdb66eda2200c6460/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L133) and phantom references (https://github.com/apache/sling/blob/b864f105617c0ac7c2d525bfdb66eda2200c6460/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L504). In case of acting on top of a request one could leverage ServletRequestListener.requestDestroyed(...) instead, which is more reliable and called earlier than relying on phantom references.

Issue Links

• relates to: SLING-9036 Sling Models: SlingHttpServletRequestWrapper.adaptTo() unwraps before adapting
• links to: GitHub Pull Request #1