[SLING-7517] Memory Leak for "fake" Request objects in ModelAdapterFactory with interface-based models

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Models Impl 1.4.6
• Fix Version/s: Models Impl 1.4.8
• Component/s: Extensions
• Assignee: Justin Edelson
• Reporter: Justin Edelson
• Created: 26/Feb/18 19:25
• Updated: 05/Mar/18 12:24
• Resolved: 26/Feb/18 19:33

Description

The functionality added in SLING-5668 to dispose of OSGi services (or anything else needing disposal when creating a Sling Model object) based on the ServletRequest lifecycle only works if the ServletRequest object was actually created by the ServletContext. In some cases, applications make construct "fake" request object (primarily for use with SlingRequestProcessor). In these cases, since the ServletContext didn't create these requests, it won't call the requestDestroyed method when they are complete.

 

The easiest way to resolve this is to only apply the special behavior in SLING-5668 to request objects actually created by the ServletContext and use the general-purpose ReferenceQueue method for all other requests (and all other adaptables).

 

The fix in SLING-7470 was incomplete and only addressed class-based models. Interface-based models were not fixed.

Issue Links

• is a clone of: SLING-7470 Memory Leak for "fake" Request objects in ModelAdapterFactory