[SLING-7320] NPE in sling commons threads

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Commons Threads 3.2.10
• Fix Version/s: Commons Threads 3.2.16
• Component/s: Commons
• Environment: Linux, jdk18
• Assignee: Konrad Windszus
• Reporter: Ivo Leitão
• Created: 20/Dec/17 11:46
• Updated: 26/Jan/18 15:49
• Resolved: 25/Jan/18 13:39

Description

I'm currently running a number of integration tests via pax exam and sometimes I see the following stacktrace. I've already seen this in a running sling also. This happens only in some runs but on that cases is breaking my CI workflow

Exception in thread "sling-default-5" java.lang.NullPointerException
at org.apache.sling.commons.threads.impl.ThreadLocalCleaner.copy(ThreadLocalCleaner.java:186)
at org.apache.sling.commons.threads.impl.ThreadLocalCleaner.saveOldThreadLocals(ThreadLocalCleaner.java:176)
at org.apache.sling.commons.threads.impl.ThreadLocalCleaner.<init>(ThreadLocalCleaner.java:51)
at org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocals.beforeExecute(ThreadPoolExecutorCleaningThreadLocals.java:55)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

Issue Links

• is broken by: SLING-6261 ThreadExpiringThreadPool is relying on uncaught exceptions to kill threads
• relates to: SLING-7447 Race condition in ThreadLocalCleaner initialization code