[SLING-6261] ThreadExpiringThreadPool is relying on uncaught exceptions to kill threads

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Commons Threads 3.2.6
• Fix Version/s: Commons Threads 3.2.10
• Component/s: Commons
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 09/Nov/16 07:54
• Updated: 27/Dec/23 10:39
• Resolved: 26/Sep/17 17:12

Description

In o.a.s.commons.threads.impl.ThreadExpiringThreadPool a RuntimeException with message "Kill old thread" is used in checkMaxThreadAge(final Thread thread). This leads by default to a suspension of the thread when debugging with Eclipse (as since Neon JDT will suspend the thread on all uncaught exceptions). More information is available in http://stackoverflow.com/questions/6290470/eclipse-debugger-always-blocks-on-threadpoolexecutor-without-any-obvious-excepti. There should be a different mechanism to kill the thread than an uncaught exception.

Issue Links

• breaks: SLING-7432 Thread pool clean up code can lead to infinite loops in ThreadLocal.get
• breaks: SLING-7320 NPE in sling commons threads
• causes: SLING-12212 Don't emit stacktrace when ThreadPoolExecutorCleaningThreadLocals cannot be initialized
• is broken by: SLING-4676 Clean up threads or refresh threads when put back into the pool
• is related to: SLING-6257 Sling IDE: Debugging: Thread interrupted for every uncaught exception