[SLING-6344] Support filter.xmls being generated by the content-package-maven-plugin

• Type: Bug
• Status: Open
• Priority: Critical
• Resolution: Unresolved
• Affects Version/s: Sling Eclipse IDE 1.1.0
• Fix Version/s: Sling Eclipse IDE 2.0.0
• Component/s: IDE
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 30/Nov/16 10:33
• Updated: 31/May/20 14:21

Description

The content-package-maven plugin can not only consume a filter.xml from the source directory, but also generate or merge filter.xmls. Therefore Sling IDE should consider only the filter.xml in the generated artifacts (package). The problem with that is, that content-package-maven-plugin does only generate that filter.xml when it generates the real package.

There is one other related issue: In case a filter file is not found, the method ResourceChangeCommandFactory#getFilterResult returns ALLOW while it should return DENY to not overwrite any nodes in case the filter rules could not be determined.

In my case those two problems lead to a modification of the jcr:primaryType of the root node in the JCR from rep:root to nt:unstructured and the resourceType from sling:redirect to just being removed which breaks the redirect handling.

Issue Links

• is blocked by: JCRVLT-246 Generate metadata like filter.xml and properties.xml in dedicated goal
• is duplicated by: SLING-7883 Sling Tools - No valid filter found in this project!
• is related to: SLING-6453 In case no filter.xml could be found nothing should be synchronized
• is related to: SLING-6950 Support Content-Package based development
• relates to: SLING-4069 Intermediate resources that do not match the filter are not created when publishing
• relates to: SLING-6081 Sling Content Package Maven Plugin