Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-6344

Support filter.xmls being generated by the content-package-maven-plugin

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Critical
    • Resolution: Unresolved
    • Sling Eclipse IDE 1.1.0
    • Sling Eclipse IDE 1.2.4
    • IDE
    • None

    Description

      The content-package-maven plugin can not only consume a filter.xml from the source directory, but also generate or merge filter.xmls. Therefore Sling IDE should consider only the filter.xml in the generated artifacts (package). The problem with that is, that content-package-maven-plugin does only generate that filter.xml when it generates the real package.

      There is one other related issue: In case a filter file is not found, the method ResourceChangeCommandFactory#getFilterResult returns ALLOW while it should return DENY to not overwrite any nodes in case the filter rules could not be determined.

      In my case those two problems lead to a modification of the jcr:primaryType of the root node in the JCR from rep:root to nt:unstructured and the resourceType from sling:redirect to just being removed which breaks the redirect handling.

      Attachments

        1. SLING-6344-v01.patch
          1 kB
          Konrad Windszus
        2. SLING-6344-v02.patch
          4 kB
          Konrad Windszus
        3. SLING-6344-v03.patch
          13 kB
          Konrad Windszus

        Issue Links

          Activity

            People

              kwin Konrad Windszus
              kwin Konrad Windszus
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated: