Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-12452

Investigate removing embeding of Oak classes

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • JCR Oak Server 1.4.2
    • Oak
    • None

    Description

      The current version of the oak-server bundle currently embeds two oak classes

      $ jar tf target/org.apache.sling.jcr.oak.server-1.4.1-SNAPSHOT.jar  | grep -E 'jackrabbit.*class'
      org/apache/jackrabbit/oak/plugins/index/lucene/util/LuceneIndexHelper.class
      org/apache/jackrabbit/oak/plugins/index/search/util/IndexHelper.class
      

      These classes seem to be responsible for pulling in the shaded Guava imports which make upgrading to new Oak version harder.

      Using bnd print --full target/org.apache.sling.jcr.oak.server-1.4.1-SNAPSHOT.jar I noticed the following usage report

      [USEDBY]
      
      (...)
      
      org.apache.jackrabbit.guava.common.base org.apache.jackrabbit.oak.plugins.index.lucene.util
                                              org.apache.jackrabbit.oak.plugins.index.search.util
      org.apache.jackrabbit.guava.common.collect org.apache.jackrabbit.oak.plugins.index.search.util
      

      If we could stop embedding the Oak classes the Guava imports should no longer be required.

      Attachments

        1. oak-server-bnd-report.txt
          22 kB
          Robert Munteanu

        Issue Links

          Activity

            People

              rombert Robert Munteanu
              rombert Robert Munteanu
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: