[SLING-12452] Investigate removing embeding of Oak classes

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: JCR Oak Server 1.4.2
• Component/s: Oak
• Assignee: Robert Munteanu
• Reporter: Robert Munteanu
• Created: 11/Oct/24 22:02
• Updated: 23/Oct/24 09:14
• Resolved: 16/Oct/24 12:42

Description

The current version of the oak-server bundle currently embeds two oak classes

$ jar tf target/org.apache.sling.jcr.oak.server-1.4.1-SNAPSHOT.jar  | grep -E 'jackrabbit.*class'
org/apache/jackrabbit/oak/plugins/index/lucene/util/LuceneIndexHelper.class
org/apache/jackrabbit/oak/plugins/index/search/util/IndexHelper.class

These classes seem to be responsible for pulling in the shaded Guava imports which make upgrading to new Oak version harder.

Using bnd print --full target/org.apache.sling.jcr.oak.server-1.4.1-SNAPSHOT.jar I noticed the following usage report

[USEDBY]

(...)

org.apache.jackrabbit.guava.common.base org.apache.jackrabbit.oak.plugins.index.lucene.util
                                        org.apache.jackrabbit.oak.plugins.index.search.util
org.apache.jackrabbit.guava.common.collect org.apache.jackrabbit.oak.plugins.index.search.util

If we could stop embedding the Oak classes the Guava imports should no longer be required.

Issue Links

• causes: SLING-12457 Make creation of Lucene index definition configurable
• is blocked by: OAK-11078 Remove usage of Guava checkArgument
• links to: GitHub Pull Request #12