[SLING-11867] Empty mapping from ResourceMapper breaks authentication requirement updates

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Auth Core 1.6.0
• Fix Version/s: Auth Core 1.6.2
• Component/s: Authentication
• Assignee: Carsten Ziegeler
• Reporter: Sagar Miglani
• Created: 10/May/23 05:43
• Updated: 23/Jul/23 07:26
• Resolved: 17/May/23 06:12

Description

When a resource has a path less url as vanity path (eg: "http://www.example.com") ResourceMapper.getAllMappings returns mappings consisting of an empty path "".

This "" mapping can make AuthenticationRequirementsManager stop listening to further authentication requirements [0]:

Exception in thread "pool-14-thread-1" java.lang.IllegalArgumentException: Configuration must not be null or empty
	at org.apache.sling.auth.core.impl.AuthenticationRequirementHolder.fromConfig(AuthenticationRequirementHolder.java:30)
	at org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.addService(AuthenticationRequirementsManager.java:374)
	at org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.process(AuthenticationRequirementsManager.java:300)
	at org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.processQueue(AuthenticationRequirementsManager.java:281)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

In SLING-11861 and [0], it was suggested to make changes in caller's code instead of changing the behaviour of ResoucreMapper.

[0]: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96

Issue Links

• relates to: SLING-11861 ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths is pathless url
• links to: GitHub Pull Request #14