[SLING-11861] ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths is pathless url

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: Resource Resolver 1.10.0
• Component/s: ResourceResolver
• Assignee: Unassigned
• Reporter: Sagar Miglani
• Created: 05/May/23 07:14
• Updated: 10/May/23 05:54
• Resolved: 10/May/23 05:54

Description

When a resource has a path less url as vanity path (eg: "http://www.example.com") ResourceMapper.getAllMappings returns mappings consisting of an empty path "".

This "" mapping can make AuthenticationRequirementsManager stop listening to further authentication requirements [0]:

Exception in thread "pool-14-thread-1" java.lang.IllegalArgumentException: Configuration must not be null or empty
	at org.apache.sling.auth.core.impl.AuthenticationRequirementHolder.fromConfig(AuthenticationRequirementHolder.java:30)
	at org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.addService(AuthenticationRequirementsManager.java:374)
	at org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.process(AuthenticationRequirementsManager.java:300)
	at org.apache.sling.auth.core.impl.AuthenticationRequirementsManager.processQueue(AuthenticationRequirementsManager.java:281)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

Clarification required:

• Is "" mapping/path a valid path? Should we store and return vanity path as "/" in case of pathless url as vanity path?

cc: cziegeler rombert reschke

[0]: https://github.com/apache/sling-org-apache-sling-auth-core/blob/org.apache.sling.auth.core-1.5.0/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticatorServiceListener.java#L345-L351

Issue Links

• is related to: SLING-11867 Empty mapping from ResourceMapper breaks authentication requirement updates
• links to: GitHub Pull Request #96