[SLING-11852] Make the ThreadsafeMockAdapterManagerWrapper use an InheritableThreadLocal - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: Testing Sling Mock 3.4.8
Component/s: Testing
Labels:
None

Description

For scenarios where the mocked OSGi framework executes calls in other threads than the test thread (e.g. servlets under test in Jetty), the only way to pass the test's AdapterManager is to directly call SlingAdaptable#setAdapterManager. However, this will affect tests starting after this initial call.

A better solution would be to make the org.apache.sling.testing.mock.sling.ThreadsafeMockAdapterManagerWrapper#THREAD_LOCAL an InheritableThreadLocal. This would allow the tests to still be executable in parallel, but threads started from a test thread (e.g. the servlets under test in Jetty) could inherit the thread local context.