[SLING-11852] Make the ThreadsafeMockAdapterManagerWrapper use an InheritableThreadLocal

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Testing Sling Mock 3.4.8
• Component/s: Testing
• Assignee: Radu Cotescu
• Reporter: Radu Cotescu
• Created: 26/Apr/23 12:23
• Updated: 02/May/23 08:20
• Resolved: 28/Apr/23 14:08

Description

For scenarios where the mocked OSGi framework executes calls in other threads than the test thread (e.g. servlets under test in Jetty), the only way to pass the test's AdapterManager is to directly call SlingAdaptable#setAdapterManager. However, this will affect tests starting after this initial call.

A better solution would be to make the org.apache.sling.testing.mock.sling.ThreadsafeMockAdapterManagerWrapper#THREAD_LOCAL an InheritableThreadLocal. This would allow the tests to still be executable in parallel, but threads started from a test thread (e.g. the servlets under test in Jetty) could inherit the thread local context.

Issue Links

• links to: GitHub Pull Request #21