Details
Major Description
Skeleton of an implementation of the Citation GeoAPI interface. The toString(), hashCode() and equals(Object) methods are omitted on intend, since they will be provided in a future patch. The methods related to identifiers (including ISBN) are also omitted, since we will discuss later about a general way to handle identifiers. Some functionality are missing compared to what the javadoc said, since the missing code will be provided in separated patches.
IP review
There is various committers to those classes. But all the changes done by other commits fall in one of those categories:
- Ancestor or ModifiableMetadata based on XPath. There is nothing left from this approach, everything has been rewritten in a totally different way.
- Implementation of toString(), hashCode() and equals(Object) methods. Those methods do not exist anymore in Geotk since we inherit an automatic mechanism based on reflection.
- Deprecation of the identifierTypes attributes in DefaultCitation. This deprecated attribute has been removed.
- Edition of the pre-defined constants. Those constants are not part anymore of DefaultCitation. They are part of an other class however (Citations), which is not included in this issue.
- Import re-ordering (apparently just used to automatic Eclipse reordering feature).
- Modification of the GeoTools copyright header during the GeoTools IP review. This header is replaced by the Apache one.
- Trivial getters and setters. There is no way the method signature could be different, since they implement methods from an interface. The bodies were only return foo; or this.foo = foo; - those bodies are more elaborated in Geotk.
We will provide a web site providing detailed information before DefaultCitation gets its final shape.