[SHIRO-605] ShiroWebModule creates out of order filter chain.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.0-RC2
• Fix Version/s: 1.4.0
• Component/s: Integration: Guice
• Labels: easyfix
• Assignee: Jared Bunting
• Reporter: Matt Traynham
• Created: 12/Dec/16 22:07
• Updated: 15/Dec/16 17:53
• Resolved: 15/Dec/16 17:40

Description

The ShiroWebModule class is creating a randomly ordered filter chain, because it's using a HashMap instead of a LinkedHashMap.

The offending line is here:
https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L144

This should be a LinkedHashMap to maintain original user order.

It does add the paths correctly:
https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L176

And correctly returns to the FilterChainProvider:
https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L135

Issue Links

• is related to: SHIRO-579 Permission filter is validating last matched path
• links to: GitHub Pull Request #51