Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-605

ShiroWebModule creates out of order filter chain.

Attach filesAttach ScreenshotVotersWatch issueWatchersLinkUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.4.0-RC2
    • 1.4.0
    • Integration: Guice

    Description

      The ShiroWebModule class is creating a randomly ordered filter chain, because it's using a HashMap instead of a LinkedHashMap.

      The offending line is here:
      https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L144

      This should be a LinkedHashMap to maintain original user order.

      It does add the paths correctly:
      https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L176

      And correctly returns to the FilterChainProvider:
      https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L135

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            deraj123 Jared Bunting
            mtraynham Matt Traynham
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment