Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-462

Authentication exceptions are swallowed

VotersWatch issueWatchersLinkUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.2.2
    • 1.2.5
    • None

    Description

      In org.apache.shiro.cas.CasFilter.onLoginFailure(AuthenticationToken, AuthenticationException, ServletRequest, ServletResponse) the passed-in AuthenticationException is not logged anywhere. In my case, a misconfigured SSL certificate error was being swallowed. The lack of logging meant I had to use a debugger to see the exception details.

      There is a similar issue with the other override of this method, in org.apache.shiro.web.filter.authc.FormAuthenticationFilter.

      Suggest logging at debug level (which is off by default in sensible setups, but can be enabled during investigations). See attached patch.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            artbristol Art O Cathain
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment