Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-462

Authentication exceptions are swallowed

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.2
    • Fix Version/s: 1.2.5
    • Labels:
      None

      Description

      In org.apache.shiro.cas.CasFilter.onLoginFailure(AuthenticationToken, AuthenticationException, ServletRequest, ServletResponse) the passed-in AuthenticationException is not logged anywhere. In my case, a misconfigured SSL certificate error was being swallowed. The lack of logging meant I had to use a debugger to see the exception details.

      There is a similar issue with the other override of this method, in org.apache.shiro.web.filter.authc.FormAuthenticationFilter.

      Suggest logging at debug level (which is off by default in sensible setups, but can be enabled during investigations). See attached patch.

        Attachments

        1. SHIRO-462.patch
          1 kB
          Art O Cathain

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                artbristol Art O Cathain
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: