Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1408

JsonDbOpensocialService->getPeople uses outdated way of processing ?fields= parameter

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.0.0
    • 2.0.0
    • PHP
    • None
    • All

    Description

      In JsonDbOpensocialService's getPeople call, there is an old way of reading the $fields parameter. It checks for $fields[0] which throws a notice since $fields is an associative array nowadays. Also, there is a nice self::adjustFields method that can be used to filter the fields.

      I've adjusted getFields to use self::adjustFields, which also removes the missing index notice. I'll attach the patch.

      Attachments

        1. shindig-php-patch
          1 kB
          Ivo Jansch

        Activity

          People

            Unassigned Unassigned
            ijansch Ivo Jansch
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: