Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1408

JsonDbOpensocialService->getPeople uses outdated way of processing ?fields= parameter

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.0
    • Component/s: PHP
    • Labels:
      None
    • Environment:
      All

      Description

      In JsonDbOpensocialService's getPeople call, there is an old way of reading the $fields parameter. It checks for $fields[0] which throws a notice since $fields is an associative array nowadays. Also, there is a nice self::adjustFields method that can be used to filter the fields.

      I've adjusted getFields to use self::adjustFields, which also removes the missing index notice. I'll attach the patch.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              ijansch Ivo Jansch
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: