Shindig
  1. Shindig
  2. SHINDIG-1408

JsonDbOpensocialService->getPeople uses outdated way of processing ?fields= parameter

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.0
    • Component/s: PHP
    • Labels:
      None
    • Environment:
      All

      Description

      In JsonDbOpensocialService's getPeople call, there is an old way of reading the $fields parameter. It checks for $fields[0] which throws a notice since $fields is an associative array nowadays. Also, there is a nice self::adjustFields method that can be used to filter the fields.

      I've adjusted getFields to use self::adjustFields, which also removes the missing index notice. I'll attach the patch.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1d 4h 40m 1 Paul Lindner 13/Aug/10 18:48
        Gavin made changes -
        Workflow jira [ 12517818 ] patch-available, re-open possible [ 12629904 ]
        Paul Lindner made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        Paul Lindner added a comment -

        patch applied, thanks!

        Show
        Paul Lindner added a comment - patch applied, thanks!
        Ivo Jansch made changes -
        Field Original Value New Value
        Attachment shindig-php-patch [ 12451896 ]
        Hide
        Ivo Jansch added a comment -

        Patch file that fixes this issue by using self::adjustFields for filtering fields.

        Show
        Ivo Jansch added a comment - Patch file that fixes this issue by using self::adjustFields for filtering fields.
        Ivo Jansch created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Ivo Jansch
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development