[SENTRY-396] The logic of Thrift multiplexedProcessor registers mutil processor isn't correct

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.0
• Fix Version/s: 1.5.0
• Assignee: shenguoquan
• Reporter: shenguoquan
• Created: 20/Aug/14 08:34
• Updated: 23/Sep/14 18:12
• Resolved: 23/Sep/14 18:12

Description

The sentry service uses multiplexedProcessor to register multi processor, but the logic isn't correct in my opinion. It use processFactory to register and the source code as following:

TMultiplexedProcessor processor = new TMultiplexedProcessor();
boolean registeredProcessor = false;
for (String processorFactory : processorFactories){
    ProcessorFactory factory = (ProcessorFactory) #create factory instance with processorFactory name
	registeredProcessor = registeredProcessor || factory.register(processor);
}

If the first factory register successfully, registeredProcessor will become true then the following factories don't get the chance to register