Uploaded image for project: 'Sentry'
  1. Sentry
  2. SENTRY-396

The logic of Thrift multiplexedProcessor registers mutil processor isn't correct

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.5.0
    • Component/s: None
    • Labels:
      None

      Description

      The sentry service uses multiplexedProcessor to register multi processor, but the logic isn't correct in my opinion. It use processFactory to register and the source code as following:

      TMultiplexedProcessor processor = new TMultiplexedProcessor();
      boolean registeredProcessor = false;
      for (String processorFactory : processorFactories){
          ProcessorFactory factory = (ProcessorFactory) #create factory instance with processorFactory name
      	registeredProcessor = registeredProcessor || factory.register(processor);
      }

      If the first factory register successfully, registeredProcessor will become true then the following factories don't get the chance to register

        Attachments

        1. SENTRY-396.patch
          1.0 kB
          shenguoquan

          Activity

            People

            • Assignee:
              guoquan shenguoquan
              Reporter:
              guoquan shenguoquan
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: