Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.0
    • Component/s: Sentry
    • Labels:
      None

      Description

      We are using old version of Guava - time to upgrade. Note that BoneCP 0.8.1 requires newer version of Guava.

      Sergio Peña Na Li kalyan kumar kalvagadda FYI

      1. SENTRY-1943.1.patch
        8 kB
        Sergio Peña
      2. SENTRY-1943.2.patch
        1 kB
        Sergio Peña
      3. SENTRY-1943.3.patch
        1 kB
        Sergio Peña

        Issue Links

          Activity

          Hide
          spena Sergio Peña added a comment -

          Thanks Alexander Kolbasov for the review.
          I committed to master.

          Show
          spena Sergio Peña added a comment - Thanks Alexander Kolbasov for the review. I committed to master.
          Hide
          akolb Alexander Kolbasov added a comment - - edited

          Sergio Peña Sure, can you upload diff to reviewboard?

          Show
          akolb Alexander Kolbasov added a comment - - edited Sergio Peña Sure, can you upload diff to reviewboard?
          Hide
          spena Sergio Peña added a comment -

          Alexander Kolbasov This is the Guava version used by the latest Hive upstream version and seems to work nicely without many changes.
          Could you review?

          Show
          spena Sergio Peña added a comment - Alexander Kolbasov This is the Guava version used by the latest Hive upstream version and seems to work nicely without many changes. Could you review?
          Hide
          hadoopqa Hadoop QA added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12887740/SENTRY-1943.3.patch against master.

          Overall: +1 all checks pass

          SUCCESS: all tests passed

          Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3298/console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12887740/SENTRY-1943.3.patch against master. Overall: +1 all checks pass SUCCESS: all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3298/console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12887169/SENTRY-1943.2.patch against master.

          Overall: -1 due to 100 errors

          ERROR: mvn test exited 1
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceClientPool
          ERROR: Failed: org.apache.sentry.provider.db.generic.tools.TestSentryConfigToolSolr
          ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestAuditLogForSentryGenericService
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceImportExport
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStoreImportExport
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceWithKerberos
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceIntegration
          ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericServiceClient
          ERROR: Failed: org.apache.sentry.provider.db.tools.TestSentryShellHive
          ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericServiceIntegration
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceMetrics
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceWithInvalidMsgSize
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServerLogLevel
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestAuthorizingDDLAuditLogWithKerberos
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryVersion
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryVersion
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryVersion
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceForPoolWithKerberos
          ERROR: Failed: org.apache.sentry.provider.db.generic.tools.TestSentryShellSolr
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServerForPoolWithoutKerberos
          ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestPrivilegeOperatePersistence
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestHMSFollowerSentryStoreIntegration
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestHMSFollowerSentryStoreIntegration
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryPolicyServiceClient
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestDelegateSentryStore
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceFailureCase
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithSSL
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithoutSecurity
          ERROR: Failed: org.apache.sentry.provider.db.generic.tools.TestSentryShellKafka
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithKerberos
          ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServerWithoutKerberos

          Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3294/console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12887169/SENTRY-1943.2.patch against master. Overall: -1 due to 100 errors ERROR: mvn test exited 1 ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceClientPool ERROR: Failed: org.apache.sentry.provider.db.generic.tools.TestSentryConfigToolSolr ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestAuditLogForSentryGenericService ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceImportExport ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStoreImportExport ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceWithKerberos ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceIntegration ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericServiceClient ERROR: Failed: org.apache.sentry.provider.db.tools.TestSentryShellHive ERROR: Failed: org.apache.sentry.provider.db.generic.service.thrift.TestSentryGenericServiceIntegration ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceMetrics ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceWithInvalidMsgSize ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServerLogLevel ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestAuthorizingDDLAuditLogWithKerberos ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryVersion ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryVersion ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryVersion ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceForPoolWithKerberos ERROR: Failed: org.apache.sentry.provider.db.generic.tools.TestSentryShellSolr ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServerForPoolWithoutKerberos ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestPrivilegeOperatePersistence ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestHMSFollowerSentryStoreIntegration ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestHMSFollowerSentryStoreIntegration ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryPolicyServiceClient ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore ERROR: Failed: org.apache.sentry.provider.db.generic.service.persistent.TestDelegateSentryStore ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceFailureCase ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithSSL ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithoutSecurity ERROR: Failed: org.apache.sentry.provider.db.generic.tools.TestSentryShellKafka ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithKerberos ERROR: Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServerWithoutKerberos Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3294/console This message is automatically generated.
          Hide
          akolb Alexander Kolbasov added a comment -

          Can we upgrade to the latest that doesn't require JDK8?

          Show
          akolb Alexander Kolbasov added a comment - Can we upgrade to the latest that doesn't require JDK8?
          Hide
          spena Sergio Peña added a comment -

          This is the error we get if we use JDK7.

          [INFO] Compiling 13 source files to /home/jenkins/jenkins-slave/workspace/PreCommit-SENTRY-Build/sentry-provider/sentry-provider-common/target/classes
          /home/jenkins/jenkins-slave/workspace/PreCommit-SENTRY-Build/sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java:136: error: cannot access Function
                  new Function<String, Privilege>() {
                  ^
            class file for java.util.function.Function not found
          1 error
          

          java.util.function.Function used on the Guava library is available on JDK8

          Show
          spena Sergio Peña added a comment - This is the error we get if we use JDK7. [INFO] Compiling 13 source files to /home/jenkins/jenkins-slave/workspace/PreCommit-SENTRY-Build/sentry-provider/sentry-provider-common/target/classes /home/jenkins/jenkins-slave/workspace/PreCommit-SENTRY-Build/sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java:136: error: cannot access Function new Function<String, Privilege>() { ^ class file for java.util.function.Function not found 1 error java.util.function.Function used on the Guava library is available on JDK8
          Hide
          spena Sergio Peña added a comment -

          The latest version of Guava (23.0) needs JDK8 in order to work.

          Show
          spena Sergio Peña added a comment - The latest version of Guava (23.0) needs JDK8 in order to work.
          Hide
          hadoopqa Hadoop QA added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12887139/SENTRY-1943.1.patch against master.

          Overall: -1 due to an error

          ERROR: failed to build with patch (exit code 1)

          Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3292/console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12887139/SENTRY-1943.1.patch against master. Overall: -1 due to an error ERROR: failed to build with patch (exit code 1) Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3292/console This message is automatically generated.

            People

            • Assignee:
              spena Sergio Peña
              Reporter:
              akolb Alexander Kolbasov
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development