Description
I noticed that multiple unit tests in TestSentryStore are not testing useful things. For example:
@Test public void testCreateDropRole() throws Exception { String roleName = "test-drop-role"; long seqId = sentryStore.createSentryRole(roleName).getSequenceId(); assertEquals(seqId + 1, sentryStore.dropSentryRole(roleName).getSequenceId()); }
So this code only tests that there are no exceptions thrown. The assert is bogus - it tests that there was a single transaction in between which is a wrong test in the first place - number of transactions isn't a functionality. The test doesn't verify whether the role was actually created and whether it was correctly dropped. And it is similar for other tests as well.
Attachments
Attachments
Issue Links
- relates to
-
SENTRY-872 Uber jira for HMS HA + Sentry HA redesign
- Resolved
-
SENTRY-1517 SentryStore should actually use function getMSentryRole to get roles
- Resolved
- links to