[SENTRY-1502] Multiple tests in TestSentryStore are not testing useful things

• Type: Test
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.7.0, 2.0.0
• Component/s: Sentry
• Labels: patch
• Assignee: Ruiming Zhou
• Reporter: Alex Kolbasov
• Created: 14/Oct/16 01:30
• Updated: 13/Sep/18 17:00

Description

I noticed that multiple unit tests in TestSentryStore are not testing useful things. For example:

@Test
  public void testCreateDropRole() throws Exception {
    String roleName = "test-drop-role";
    long seqId = sentryStore.createSentryRole(roleName).getSequenceId();
    assertEquals(seqId + 1, sentryStore.dropSentryRole(roleName).getSequenceId());
  }

So this code only tests that there are no exceptions thrown. The assert is bogus - it tests that there was a single transaction in between which is a wrong test in the first place - number of transactions isn't a functionality. The test doesn't verify whether the role was actually created and whether it was correctly dropped. And it is similar for other tests as well.

Issue Links

• relates to: SENTRY-872 Uber jira for HMS HA + Sentry HA redesign
• relates to: SENTRY-1517 SentryStore should actually use function getMSentryRole to get roles
• links to: Review Board