Uploaded image for project: 'Sentry (Retired)'
  1. Sentry (Retired)
  2. SENTRY-872 Uber jira for HMS HA + Sentry HA redesign
  3. SENTRY-1329

Adapt SentryMetaStorePostEventListener to write HMS notification logs

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0
    • Hdfs Plugin
    • None

    Description

      After some preliminary testing of HMS NotificationLog in Sentry (SENTRY-1324), we see that NotificationLog does not capture some information today. See this comment for more information.

      So with respect to capturing this information, the minimally invasive approach is to just implement a custom MessageFactory (hcatalog.message.factory.impl.json), which takes care of the serialization and deseriazation of the message. We can just add additional information without causing disruption to other clients.

      As I was implementing this, I encountered the problem that there is a small bug(in Hive trunk) which makes the MessageFactory not truly pluggable (HIVE-14011 - Attached a fix). But it would be a while before Hive can make a release with this fix and Sentry can move to this fixed version.

      So in the interim, we can implement the Listener in Sentry and use custom MessageFactory as well. I have done some testing on my side to make sure it does not break other clients.

      Attachments

        1. SENTRY-1329.0.patch
          64 kB
          Sravya Tirukkovalur
        2. SENTRY-1329.1-sentry-ha-redesign.patch
          82 kB
          Sravya Tirukkovalur
        3. SENTRY-1329.2-sentry-hs-redesign.patch
          126 kB
          Sravya Tirukkovalur
        4. SENTRY-1329.2-sentry-ha-redesign.patch
          125 kB
          Sravya Tirukkovalur
        5. SENTRY-1329.2-sentry-ha-redesign.patch
          125 kB
          Sravya Tirukkovalur
        6. SENTRY-1329.3-sentry-ha-redesign.patch
          125 kB
          Sravya Tirukkovalur
        7. SENTRY-1329.4-sentry-ha-redesign.patch
          127 kB
          Sravya Tirukkovalur
        8. SENTRY-1329.5-sentry-ha-redesign.patch
          127 kB
          Sravya Tirukkovalur
        9. SENTRY-1329.6-sentry-ha-redesign.patch
          127 kB
          Sravya Tirukkovalur

        Issue Links

          Activity

            People

              sravya Sravya Tirukkovalur
              sravya Sravya Tirukkovalur
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: