Details
-
Sub-task
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
Description
After some preliminary testing of HMS NotificationLog in Sentry (SENTRY-1324), we see that NotificationLog does not capture some information today. See this comment for more information.
So with respect to capturing this information, the minimally invasive approach is to just implement a custom MessageFactory (hcatalog.message.factory.impl.json), which takes care of the serialization and deseriazation of the message. We can just add additional information without causing disruption to other clients.
As I was implementing this, I encountered the problem that there is a small bug(in Hive trunk) which makes the MessageFactory not truly pluggable (HIVE-14011 - Attached a fix). But it would be a while before Hive can make a release with this fix and Sentry can move to this fixed version.
So in the interim, we can implement the Listener in Sentry and use custom MessageFactory as well. I have done some testing on my side to make sure it does not break other clients.
Attachments
Attachments
Issue Links
- depends upon
-
SENTRY-1324 Add sentry specific test cases to use NotificationLog
- Resolved
- links to