Uploaded image for project: 'Sentry'
  1. Sentry
  2. SENTRY-1269

Converter vs Convertor is inconsistent

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.0
    • Fix Version/s: 1.8.0
    • Component/s: Solr Plugin
    • Labels:
      None

      Description

      ./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java: public static final String PRIVILEGE_CONVERTER = "sentry.provider.backend.generic.privilege.converter";

      But the individual types are defined as Convertors:
      ./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/TSentryPrivilegeConvertor.java
      ./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConvertor.java
      ./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConvertor.java
      ./sentry-provider/sentry-provider-db/target/classes/org/apache/sentry/provider/db/generic/tools/command/TSentryPrivilegeConvertor.class
      ./sentry-provider/sentry-provider-db/target/classes/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConvertor.class
      ./sentry-provider/sentry-provider-db/target/classes/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConvertor.class

      This is American vs British spelling, most projects seem to go with American (Converter). We should make this consistent before we do a release.

        Attachments

        1. SENTRY-1269.patch
          47 kB
          Gregory Chanan

          Issue Links

            Activity

              People

              • Assignee:
                gchanan Gregory Chanan
                Reporter:
                gchanan Gregory Chanan
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: