[SENTRY-1269] Converter vs Convertor is inconsistent

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.8.0
• Component/s: Solr Plugin
• Assignee: Gregory Chanan
• Reporter: Gregory Chanan
• Created: 18/May/16 01:28
• Updated: 21/May/16 02:24
• Resolved: 19/May/16 22:42

Description

./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java: public static final String PRIVILEGE_CONVERTER = "sentry.provider.backend.generic.privilege.converter";

But the individual types are defined as Convertors:
./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/TSentryPrivilegeConvertor.java
./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConvertor.java
./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConvertor.java
./sentry-provider/sentry-provider-db/target/classes/org/apache/sentry/provider/db/generic/tools/command/TSentryPrivilegeConvertor.class
./sentry-provider/sentry-provider-db/target/classes/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConvertor.class
./sentry-provider/sentry-provider-db/target/classes/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConvertor.class

This is American vs British spelling, most projects seem to go with American (Converter). We should make this consistent before we do a release.

Issue Links

• is duplicated by: SENTRY-1268 Add solr privilege convertor by default to solr binding