Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.16
    • Component/s: REEF.NET
    • Labels:

      Activity

      Hide
      markus.weimer Markus Weimer added a comment -

      Resolved via #1279

      Show
      markus.weimer Markus Weimer added a comment - Resolved via #1279
      Hide
      singlis Scott Inglis added a comment -

      Markus Weimer I have posted new changes to this, please review when you get a chance. Couple of things to mention:
      1) Restore should now work when restoring from the solution. This should restore both Utilities and Tang projects, which should then fix the build errors.
      2) I successfully tested with both an old version of dotnet cli tools (1.3) and the latest 2.0 toolset installed using the installer. The build now works – I believe this is fixed in the dotnet tools as I have not been able to pin this down to a specific change. I did however remove the NetImplicitStandard attribute which targets the .net standard library to use. I noticed that the dotnet cli tools no longer specify this creating a default project – so it looks like its no longer needed. Ideally it would be great to specify a minimum version of the .net standand library (like 2.0), but I have not seen a way to do wild card with this tag as it has to be specific.

      Here is more info:
      https://docs.microsoft.com/en-us/dotnet/articles/core/tools/csproj

      Let me know if you have any problems building.

      Show
      singlis Scott Inglis added a comment - Markus Weimer I have posted new changes to this, please review when you get a chance. Couple of things to mention: 1) Restore should now work when restoring from the solution. This should restore both Utilities and Tang projects, which should then fix the build errors. 2) I successfully tested with both an old version of dotnet cli tools (1.3) and the latest 2.0 toolset installed using the installer. The build now works – I believe this is fixed in the dotnet tools as I have not been able to pin this down to a specific change. I did however remove the NetImplicitStandard attribute which targets the .net standard library to use. I noticed that the dotnet cli tools no longer specify this creating a default project – so it looks like its no longer needed. Ideally it would be great to specify a minimum version of the .net standand library (like 2.0), but I have not seen a way to do wild card with this tag as it has to be specific. Here is more info: https://docs.microsoft.com/en-us/dotnet/articles/core/tools/csproj Let me know if you have any problems building.
      Hide
      singlis Scott Inglis added a comment -

      Markus - I have made a number of updates based upon your comments. I also updated the build.md to now have instructions on how to build the dot net projects. Please review when you have a chance.

      Thanks everyone for the feedback.

      Show
      singlis Scott Inglis added a comment - Markus - I have made a number of updates based upon your comments. I also updated the build.md to now have instructions on how to build the dot net projects. Please review when you have a chance. Thanks everyone for the feedback.
      Hide
      kanjilal Saikat Kanjilal added a comment -

      Scott Inglis lets make sure to coordinate efforts as REEF-1583 is focused on moving the whole codebase to using .net framework 451, ping me for more details

      Show
      kanjilal Saikat Kanjilal added a comment - Scott Inglis lets make sure to coordinate efforts as REEF-1583 is focused on moving the whole codebase to using .net framework 451, ping me for more details
      Hide
      singlis Scott Inglis added a comment -
      Show
      singlis Scott Inglis added a comment - Pull Request: https://github.com/apache/reef/pull/1279
      Hide
      dougservice Doug Service added a comment -

      Be sure and run the latest version of the .NET compatibility tool when you start to verify what needs to be fixed as .NET Core has been somewhat of a moving target.

      Show
      dougservice Doug Service added a comment - Be sure and run the latest version of the .NET compatibility tool when you start to verify what needs to be fixed as .NET Core has been somewhat of a moving target.
      Hide
      dougservice Doug Service added a comment -

      Appears that 1.1 compatibility is now a moving target.

      Show
      dougservice Doug Service added a comment - Appears that 1.1 compatibility is now a moving target.

        People

        • Assignee:
          singlis Scott Inglis
          Reporter:
          dougservice Doug Service
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development