[REEF-1512] Enable FxCop with Managed Minimum Rules rule set

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Sergey Dudoladov
• Created: 10/Aug/16 21:38
• Updated: 14/Aug/16 22:30

Description

The FxCop utility provides static code analysis for .NET.
The FxCop version in Visual Studio has a pre-configured Managed Minimun Rules rule set , but lacks integration with GitHub infrastructure. However, we still can configure a standalone FxCop with the same set of rules, which would enable us to automatically catch common programming errors.

Violations of these rules should fail builds. Also, we should add an FxCop "pass" badge on GitHub.

Issue Links

• Is contained by: REEF-820 Adopt FxCop for REEF.NET

Sub-Tasks

• Enable the FxCop rule "CA1001 Types that own disposable fields should be disposable": Open
• Enable the FxCop rule "CA1821 Remove empty finalizers ": Open
• Enable the FxCop rule "CA2213: Disposable fields should be disposed": Open
• Enable the FxCop rule "CA2231: Overload operator equals on overriding ValueType.Equals": Open