Uploaded image for project: 'Ratis'
  1. Ratis
  2. RATIS-2099

Cache TermIndexImpl instead of using anonymous class

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • None
    • 3.1.0
    • server
    • None

    Description

      VisualVM profiler shows a top heap consumer is "TermIndex$1"

      While it doesn't say what it is exactly, it looks like EMPTY_ARRAY isn't used and can be removed.

      public interface TermIndex extends Comparable<TermIndex> {
  TermIndex[] EMPTY_ARRAY = {};

      Attachments

        Issue Links

        causes

        Sub-task - The sub-task of the issue RATIS-2132 Revert RATIS-2099 due to its performance regression

        • Major - Major loss of function.
        • Resolved

        Improvement - An improvement or enhancement to an existing feature or task. RATIS-2129 Low replication performance because of lock contention on RaftLog

        • Blocker - Blocks development and/or testing work, production could not run
        • Resolved
        is related to

        Improvement - An improvement or enhancement to an existing feature or task. RATIS-2101 Move TermIndex.PRIVATE_CACHE to Util.CACHE

        • Major - Major loss of function.
        • Resolved
        links to

        Web Link GitHub Pull Request #1100

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Symious Janus Chow
            weichiu Wei-Chiu Chuang
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 10m
                1h 10m

                Slack

                  Issue deployment