[RATIS-2099] Cache TermIndexImpl instead of using anonymous class

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 3.1.0
• Component/s: server
• Assignee: Janus Chow
• Reporter: Wei-Chiu Chuang
• Created: 22/May/24 21:13
• Updated: 10/Sep/24 21:59
• Resolved: 24/May/24 09:52

Description

VisualVM profiler shows a top heap consumer is "TermIndex$1"

While it doesn't say what it is exactly, it looks like EMPTY_ARRAY isn't used and can be removed.

public interface TermIndex extends Comparable<TermIndex> {
  TermIndex[] EMPTY_ARRAY = {};

Issue Links

• causes: RATIS-2132 Revert RATIS-2099 due to its performance regression
• causes: RATIS-2129 Low replication performance because of lock contention on RaftLog
• is related to: RATIS-2101 Move TermIndex.PRIVATE_CACHE to Util.CACHE
• links to: GitHub Pull Request #1100