Uploaded image for project: 'Ratis'
  1. Ratis
  2. RATIS-1646 Fix suppressed Findbugs warnings
  3. RATIS-1647

Fix EI_EXPOSE_REP in DataStreamRequest implementations

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0, 2.4.1
    • Streaming
    • None

    Description

      // DataStreamRequestByteBuffer
      // DataStreamRequestFilePositionCount
      // DataStreamRequestByteBuf
      // DataStreamRequestHeader
        private WriteOption[] options;
      

      The options field above currently is an array so that it causes EI_EXPOSE_REP.

      The problem is that the getWriteOptions() method below in DataStreamRequest returns an array. We probably should deprecate it and add a new method to return a List.

        //DataStreamRequest
        WriteOption[] getWriteOptions();
      

      Attachments

        1. 716_review.patch
          27 kB
          Tsz-wo Sze

        Issue Links

          Activity

            People

              swamirishi Swaminathan Balachandran
              szetszwo Tsz-wo Sze
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m