[RATIS-1646] Fix suppressed Findbugs warnings

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.1.0
• Assignee: Ethan Rose
• Reporter: Tsz-wo Sze
• Created: 29/Jul/22 17:16
• Updated: 19/Jan/24 07:43
• Resolved: 19/Jan/24 07:36

Description

There are quite a few @SuppressFBWarnings tags in the code. We should fix the underlying problems or document the reason of the suppression.

Issue Links

• relates to: RATIS-1308 Findbugs check is failing silently

Sub-Tasks

• Fix EI_EXPOSE_REP in DataStreamRequest implementations: Resolved
• Fix EI_EXPOSE_REP in MD5Hash: Resolved
• Fix SF_SWITCH_NO_DEFAULT in PureJavaCrc32C: Resolved
• Fix IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD in SlidingWindow: Resolved
• Fix NP_NULL_PARAM_DEREF in GrpcServerProtocolService: Resolved
• Fix NP_NULL_PARAM_DEREF in DataStreamManagement: Resolved
• Fix the suppressed findbugs warnings in SimpleStateMachineStorage: Resolved
• Fix URF_UNREAD_FIELD in MetricServerCallListener: Resolved
• Fix DM_EXIT in filestore Client: Resolved
• Fix findbugs warnings in LogSegmentPath: Resolved
• Fix IT_NO_SUCH_ELEMENT in InstallSnapshotRequests: Resolved
• Fix EQ_COMPARETO_USE_OBJECT_EQUALS in LogSegment: Resolved
• Remove dependency on spotbugs-annotations: Resolved