[QPID-3519] Refactor the logic behind sending of the selector arguments during subscription creation

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.15
• Component/s: JMS AMQP 0-x
• Assignee: Keith Wall
• Reporter: Robbie Gemmell
• Created: 05/Oct/11 09:52
• Updated: 14/Mar/17 20:08
• Resolved: 09/Nov/11 08:58

Description

In current implementation the FieldTable with JMS selector is created in AMQSession#createConsumerImpl.

The 0-8 MessageConsumer code creates a new FieldTable objects when sending its BasicConsime method.

The 0-10 AMQSession code does send an arguments map sourced from the consumer when doing the 'sendConsume' method.

Also, both clients send FieldTable with the selector argument they do it using different FieldTable objects.

This needs to be improved to allow both clients to reuse the same code.